Skip to content

cloud: add v1beta2 Premium API#22797

Open
Oreoxmt wants to merge 3 commits intopingcap:release-8.5from
Oreoxmt:cloud/v1beta2-premium-api
Open

cloud: add v1beta2 Premium API#22797
Oreoxmt wants to merge 3 commits intopingcap:release-8.5from
Oreoxmt:cloud/v1beta2-premium-api

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Apr 23, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt self-assigned this Apr 23, 2026
@Oreoxmt Oreoxmt added needs-cherry-pick-master Should cherry pick this PR to master branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Apr 23, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2026
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Apr 23, 2026

/cc @qqqdan

@ti-chi-bot ti-chi-bot Bot requested a review from qqqdan April 23, 2026 10:48
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the TiDB Cloud API v1beta2 for managing Premium instances, updating the API documentation and release notes accordingly. The review feedback provides several improvements to ensure consistency with the documentation style guide, including correcting heading casing, removing unnecessary filler words, and standardizing capitalization in list descriptions.

Comment thread api/tidb-cloud-api-v1beta2.md
Comment thread api/tidb-cloud-api-v1beta2.md
Comment thread api/tidb-cloud-api-v1beta2.md
Comment thread api/tidb-cloud-api-v1beta2.md Outdated
Comment thread tidb-cloud/releases/tidb-cloud-release-notes.md Outdated
Comment thread tidb-cloud/releases/tidb-cloud-release-notes.md
qiancai
qiancai approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-cloud/releases/tidb-cloud-release-notes.md Outdated
Comment thread api/tidb-cloud-api-v1beta2.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 24, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 24, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-24 07:43:25.212555226 +0000 UTC m=+2324610.417915273: ☑️ agreed by qiancai.

@Oreoxmt @qiancai
Apply suggestions from code review
deb710a 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2026
qqqdan
qqqdan approved these changes Apr 28, 2026
View reviewed changes
Comment thread api/tidb-cloud-api-v1beta2.md
- [TiDB Cloud Premium API](https://docs.pingcap.com/tidbcloud/api/v1beta2/premium): manage TiDB Cloud Premium instances, backups, and regions. This API includes the following resources:

- **TiDB Cloud Premium Instance**: manage the lifecycle and configuration of TiDB Cloud Premium instances, including passwords, CA certificates, and cloud provider information.
- **Backup**: manage backups for TiDB Cloud Premium instances, including backup-based restore.
Copy link
Copy Markdown
Contributor

@qqqdan qqqdan Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Backup**: manage backups for TiDB Cloud Premium instances, including backup-based restore.

Comment thread tidb-cloud/releases/tidb-cloud-release-notes.md
- Introduce TiDB Cloud Premium API (v1beta2) for managing the following resources automatically and efficiently:

- **TiDB Cloud Premium Instance**: manage the lifecycle and configuration of TiDB Cloud Premium instances, including passwords, CA certificates, and cloud provider information.
- **Backup**: manage backups for TiDB Cloud Premium instances, including backup-based restore.
Copy link
Copy Markdown
Contributor

@qqqdan qqqdan Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Backup**: manage backups for TiDB Cloud Premium instances, including backup-based restore.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 28, 2026

@qqqdan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qqqdan qqqdan qqqdan approved these changes

@qiancai qiancai qiancai approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-cloud-release This PR is related to TiDB Cloud release. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-master Should cherry pick this PR to master branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Oreoxmt @qqqdan @qiancai